Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add button to easily switch to SD card directory. #13885

Merged
merged 6 commits into from
Jan 7, 2021

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jan 7, 2021

image

(just realized the Home button is redundant on the screenshot, will fix that).

This uses a variety of tricks to figure out where the additional SD card is. If one is available, show a button.

Not tested on a lot of devices yet. There's also not yet a selector in case there are multiple SD cards (not sure how many devices support that....)

This probably won't work on Android 12 and later (see #11997 ) , but until then and on older devices it will be useful.

Fixes (or at least tries to) #10199, at least for some devices. Additionally adds graphics for an upcoming fullscreen toggle button.

Might help #13827 ?

Tested on:

  • Pocophone F1
  • Huawei Honor 7S
  • ASUS Zenfone 5

This will disappear in future Android versions but can be useful for
older devices.

Fixes (or at least tries to) #10199, at least for some devices.

Might help #13827 ?

Tested on Pocophone F1.
@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Jan 7, 2021
@hrydgard hrydgard added this to the v1.11.0 milestone Jan 7, 2021
@hrydgard hrydgard marked this pull request as ready for review January 7, 2021 08:40
@hrydgard
Copy link
Owner Author

hrydgard commented Jan 7, 2021

This is at a useful state now and doesn't crash on old phones anymore. I'm gonna merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant